RFR: 8307480: Improve SA "transported core" documentation for windows [v3]

Poonam Bajaj poonam at openjdk.org
Thu May 11 16:13:23 UTC 2023


On Tue, 9 May 2023 20:22:28 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> The SA document `transported_core.html` contains some tips on getting core files to work when debugging it on a machine other than the one that produced it. There are a few improvements that can be made based on information provided in [JDK-8306437](https://bugs.openjdk.org/browse/JDK-8306437) and in the #13530 review (which was eventually pulled as not necessary).
>> 
>> Updates to the document include the use of `sun.jvm.hotspot.debugger.windbg.imagePath` and `sun.jvm.hotspot.debugger.windbg.symbolPath` properties, and adding "`srv*https://msdl.microsoft.com/download/symbols`" to symbolPath.
>> 
>> The rendered html file with these changes can be found here:
>> https://htmlpreview.github.io/?https://raw.githubusercontent.com/openjdk/jdk/75b10f672a461d3742c51db06ec2625605e45cf0/src/jdk.hotspot.agent/doc/transported_core.html
>
> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use backslash for directory separator. some additional clarifications.

src/jdk.hotspot.agent/doc/transported_core.html line 90:

> 88: 
> 89: <p>
> 90: By default symbols are also located using <b>PATH</b>. However, there are also Java properties that can be used to specify both the location of the binaries, and also separately the location of symbols. Use <b>sun.jvm.hotspot.debugger.windbg.imagePath</b> for the location of binaries, and use <b>sun.jvm.hotspot.debugger.windbg.symbolPath</b> for the location of symbols. <b>imagePath</b> defaults to <b>PATH</b> if not set, and <b>symbolPath</b> defaults to <b>imagePath</b>. The advantage of using these propeties is that you don't need to change your <b>PATH</b> setting, and they allow for binaries to be located separately from symbols.

Is "also" needed here? The sentence makes more sense without it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13849#discussion_r1191402324


More information about the serviceability-dev mailing list