RFR: 8306471: Add virtual threads support to JDWP ThreadReference.Stop and JDI ThreadReference.stop() [v10]

[Chris Plummer]

On Fri, 12 May 2023 03:30:34 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update linenumber for breakpoint. It changed with a recent commit that added a comment.
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/stop/stop002.java line 154:
> 
>> 152:                 log.complain("TEST #1 FAILED: expected IllegalArgumentException was not thrown");
>> 153:                 tot_res = Consts.TEST_FAILED;
>> 154:             } catch (InvalidTypeException ee) {
> 
> It is confusing that the log.complain at line 152 expects `IllegalArgumentException` but the really expected exception is `InvalidTypeException`. Is it intentional? If so then it is better to clarify it in the comment.

Yes, this looks like a pre-existing bug. I'll cleanup the message.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13548#discussion_r1191876941