RFR: 8306471: Add virtual threads support to JDWP ThreadReference.Stop and JDI ThreadReference.stop() [v11]

[Chris Plummer]

On Fri, 12 May 2023 06:37:10 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix error message to print correct exception name
>
> src/jdk.jdi/share/classes/com/sun/jdi/ThreadReference.java line 132:
> 
>> 130:      * @throws OpaqueFrameException if the thread is a suspended
>> 131:      * virtual thread and the implementation was unable to throw an
>> 132:      * asynchronous exception from the current frame
> 
> I think "from the thread's current frame" might be a bit clearer here, more so than the JDWP spec because the current frame could be read as the current JDI (if you see what I mean). What you have is okay too, but like the JDWP spec, could be a bit clearer.

Ok, but JVMTI doesn't use the wording you suggest, and it seems it is in the same situation.


        <error id="JVMTI_ERROR_OPAQUE_FRAME">
          The thread is a suspended virtual thread and the implementation was unable
          to throw an asynchronous exception from the current frame.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13548#discussion_r1191983680