RFR: 8304685: heap-buffer-overflow in libjdwp [v2]
    Kevin Walls 
    kevinw at openjdk.org
       
    Fri May 12 20:29:50 UTC 2023
    
    
  
> Problem call to skipWhitespace in dbgsysExec src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c:91
> 
> We call skipWhitespace even when the loop will terminate, should guard against the last skipWhitespace call on the last iteration.
> 
> Could be done differently with the skipWhitespace call at the start of the loop, but skipped on the first iteration, but leaving the statements in the loop in the same order seems more readable.
Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
  move skipWhitespace to start
-------------
Changes:
  - all: https://git.openjdk.org/jdk/pull/13964/files
  - new: https://git.openjdk.org/jdk/pull/13964/files/762566ed..1b183f54
Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13964&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13964&range=00-01
  Stats: 5 lines in 1 file changed: 1 ins; 4 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/13964.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13964/head:pull/13964
PR: https://git.openjdk.org/jdk/pull/13964
    
    
More information about the serviceability-dev
mailing list