RFR: 8306593: Fix nsk/jdi/stop/stop001 for virtual threads and remove from problem list

[Serguei Spitsyn]

On Fri, 12 May 2023 20:46:41 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> nsk/jdi/stop/stop001 is problem listed due to [JDK-7034630](https://bugs.openjdk.org/browse/JDK-7034630), but that issue doesn't seem to reproduce anymore. It's suspected that it was only an issue on Solaris. For this reason stop001 should be removed from the problem list. However, it will fail due to lacking virtual thread support, so this issue also needs to be fixed at the same time. The issue is that for virtual threads, after work for [JDK-8306434](https://bugs.openjdk.org/browse/JDK-8306434) and [JDK-8306471](https://bugs.openjdk.org/browse/JDK-8306471) is complete, the test needs to expect IllegalThreadStateException rather than the stop() call succeeding.

Looks good.
Thanks,
Serguei

test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/stop/stop001.java line 272:

> 270:                 log2("       returned string is: " + line);
> 271:                 if (vthreadMode) {
> 272:                     // Because the stop() called failed, stop001a.tObj should be "null".

Nit: Is it a typo: `top() called failed` => `stop() call failed` ?

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13966#pullrequestreview-1425246986
PR Review Comment: https://git.openjdk.org/jdk/pull/13966#discussion_r1192855700