RFR: 8304685: heap-buffer-overflow in libjdwp [v2]

[Serguei Spitsyn]

On Fri, 12 May 2023 20:29:50 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Problem call to skipWhitespace in dbgsysExec src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c:91
>> 
>> We call skipWhitespace even when the loop will terminate, should guard against the last skipWhitespace call on the last iteration.
>> 
>> Could be done differently with the skipWhitespace call at the start of the loop, but skipped on the first iteration, but leaving the statements in the loop in the same order seems more readable.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   move skipWhitespace to start

Looks good.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13964#pullrequestreview-1425266773