RFR: 8307369: Add execution of all svc tests in CI [v2]
Chris Plummer
cjplummer at openjdk.org
Mon May 15 23:17:46 UTC 2023
On Fri, 12 May 2023 23:39:51 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> The fix excludes svc tests which should be updated to work with the virtual threads factory.
>> Also, ProcessTools updated to skip '-m' '--module' execution, which could not be run with test thread factory
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>
> excluded 1 more test after testing
Changes requested by cjplummer (Reviewer).
test/lib/jdk/test/lib/process/ProcessTools.java line 402:
> 400: final List<String> unsupportedArgs = List.of(
> 401: "-jar", "-cp", "-classpath", "--class-path", "--describe-module", "-d",
> 402: "--dry-run", "--list-modules","--validate-modules", "-m", "--module", "-version");
Can you fix the indentation on line 398 above?
-------------
PR Review: https://git.openjdk.org/jdk/pull/13968#pullrequestreview-1427480086
PR Review Comment: https://git.openjdk.org/jdk/pull/13968#discussion_r1194441734
More information about the serviceability-dev
mailing list