RFR: 8307369: Add execution of all svc tests in CI [v2]

Leonid Mesnik lmesnik at openjdk.org
Tue May 16 00:08:46 UTC 2023


On Mon, 15 May 2023 23:14:37 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> test/lib/jdk/test/lib/process/ProcessTools.java line 402:
>> 
>>> 400:         final List<String> unsupportedArgs = List.of(
>>> 401:              "-jar", "-cp", "-classpath", "--class-path", "--describe-module", "-d",
>>> 402:              "--dry-run", "--list-modules","--validate-modules", "-m", "--module", "-version");
>> 
>> Can you fix the indentation on line 398 above?
>
> It doesn't seem to make much sense to have an argument be in both `unsupportedArgs` and `doubleWordArgs`. `unsupportedArgs` seems to take precedence and the arg will never have a change to be found in `doubleWordArgs`.

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13968#discussion_r1194466765


More information about the serviceability-dev mailing list