RFR: 8307968: serviceability/jvmti/vthread/StopThreadTest/StopThreadTest.java timed out [v2]

Serguei Spitsyn sspitsyn at openjdk.org
Tue May 16 01:23:43 UTC 2023


On Mon, 15 May 2023 21:41:11 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   moved Thread.interrupted() in StopThreadTest.java above a couple of lines
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTest/StopThreadTest.java line 208:
> 
>> 206:                 StopThreadTest.setFailed("TestTask.run: expected AssertionError from method A()");
>> 207:             }
>> 208:             Thread.interrupted();
> 
> I'm not sure why this was move down this far. It seems you would want to do this before the `StopThreadTest.setFailed()` call just to be extra safe, so that means move it before the `if` statement.

Good suggestion. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13969#discussion_r1194498212


More information about the serviceability-dev mailing list