RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v11]

Paul Hohensee phh at openjdk.org
Tue May 16 04:35:50 UTC 2023


On Tue, 9 May 2023 01:40:20 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> src/hotspot/share/runtime/atomic.hpp line 310:
>> 
>>> 308: 
>>> 309:   // Platform-specific implementation of add.  Support for sizes of 4
>>> 310:   // and 8 bytes are required.  The class must be default constructable,
>> 
>> Comment change seems unnecessary.
>
> I found that I had to add 64-bit atomic add support on 32-bit platforms (working on it), so I changed the comment to match the similar cmpxchg one.

Reverted, since 64-bit atomic add is no longer needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13814#discussion_r1194447125


More information about the serviceability-dev mailing list