RFR: 8307968: serviceability/jvmti/vthread/StopThreadTest/StopThreadTest.java timed out [v2]
Serguei Spitsyn
sspitsyn at openjdk.org
Tue May 16 06:13:49 UTC 2023
On Tue, 16 May 2023 01:57:39 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>>
>> moved Thread.interrupted() in StopThreadTest.java above a couple of lines
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTest/StopThreadTest.java line 107:
>
>> 105: testTaskThread = Thread.ofPlatform().name("TestTaskThread").start(testTask);
>> 106: }
>> 107: testTask.ensureAtPointA();
>
> Java Code Conventions recommends to use className and not variables while calling static methods. Same for 'ensureFinished()'.
Thank you. Fixed now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13969#discussion_r1194654203
More information about the serviceability-dev
mailing list