RFR: 8308237: add JDWP and JDI virtual thread support for ThreadReference.PopFrames [v2]

Wed May 17 20:27:10 UTC 2023

On Wed, 17 May 2023 08:31:20 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change "The specified thread" to "This thread"
>
> src/jdk.jdi/share/classes/com/sun/jdi/ThreadReference.java line 380:
> 
>> 378:      * This method may be used to pop frames of a virtual thread when
>> 379:      * it is suspended at an event. An implementation may support popping
>> 380:      * the frames of a suspended virtual thread in other cases.
> 
> This text looks okay but I notice a bit further up that it says "The specified thread must be suspended". I assume that should be "This thread must be suspended".

Ok. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14022#discussion_r1197014366