Integrated: 8304685: Fix whitespace parsing in libjdwp

Kevin Walls kevinw at openjdk.org
Fri May 19 19:01:00 UTC 2023


On Fri, 12 May 2023 18:32:35 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Problem call to skipWhitespace in dbgsysExec src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c:91
> 
> We call skipWhitespace even when the loop will terminate, should guard against the last skipWhitespace call on the last iteration.
> 
> Could be done differently with the skipWhitespace call at the start of the loop, but skipped on the first iteration, but leaving the statements in the loop in the same order seems more readable.

This pull request has now been integrated.

Changeset: 939344b8
Author:    Kevin Walls <kevinw at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/939344b8433b32166f42ad73ae3d96e84b033478
Stats:     3 lines in 1 file changed: 1 ins; 1 del; 1 mod

8304685: Fix whitespace parsing in libjdwp

Reviewed-by: cjplummer, amenkov, sspitsyn

-------------

PR: https://git.openjdk.org/jdk/pull/13964


More information about the serviceability-dev mailing list