RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v24]
Kevin Walls
kevinw at openjdk.org
Wed May 24 15:49:11 UTC 2023
On Wed, 24 May 2023 14:40:21 GMT, Paul Hohensee <phh at openjdk.org> wrote:
>> Please review this addition to com.sun.management.ThreadMXBean that returns the total number of bytes allocated on the Java heap since JVM launch by both terminated and live threads.
>>
>> Because this PR adds a new interface method, I've updated the JMM_VERSION to 4, but would be happy to update it to 3_1 instead.
>
> Paul Hohensee has updated the pull request incrementally with 63 additional commits since the last revision:
>
> - 8304074: Change UnsupportedOperationException in javadoc comment to {@code UnsupportedOperationException}
> - 8306507: [linux] Print number of memory mappings in error reports
>
> Reviewed-by: adinn, sgehwolf
> - 8300086: Replace NULL with nullptr in share/c1/
>
> Reviewed-by: thartmann, chagedorn
> - 8308465: Reduce memory accesses in AArch64 MD5 intrinsic
>
> Reviewed-by: aph, phh
> - 8302218: CHeapBitMap::free frees with incorrect size
>
> Reviewed-by: aboldtch, iklam, tschatzl
> - 8308388: Update description of SourceVersion.RELEASE_21
>
> Reviewed-by: iris
> - 8307190: Refactor ref_at methods in Constant Pool
>
> Reviewed-by: coleenp, iklam
> - 8308458: Windows build failure with disassembler.cpp(792): warning C4267: '=': conversion from 'size_t' to 'int'
>
> Reviewed-by: jiefu
> - 8308034: Some CDS tests need to use @requires vm.flagless
>
> Reviewed-by: iklam
> - 8307573: Implementation of JEP 449: Deprecate the Windows 32-bit x86 Port for Removal
>
> Reviewed-by: erikj
> - ... and 53 more: https://git.openjdk.org/jdk/compare/7ee35da0...638756de
This review now contains a lot of other changes: Files changed 725
Hopefully they all get squashed appropriately? But other changes already integrated don't normally show up here as part of the review, or in the generated webrevs. I looked at an earlier webrev and thought it looked good, but now it's hard to see the actual changes... 8-)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13814#issuecomment-1561419991
More information about the serviceability-dev
mailing list