RFR: 8308819: add JDWP and JDI virtual thread support for ThreadReference.ForceEarlyReturn

Serguei Spitsyn sspitsyn at openjdk.org
Fri May 26 07:35:56 UTC 2023


On Fri, 26 May 2023 03:21:12 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> Improve ThreadReference.ForceEarlyReturn to support virtual threads as long as they are suspended and mounted.
> 
> [JDK-8308400](https://bugs.openjdk.org/browse/JDK-8308400) improved JVMTI ForceEarlyReturn support for virtual threads. The spec now says it is supported if the thread is suspended at an event (not a specific event as previously spec'd), and additional support may also be provided. The implementation now just requires that the virtual thread be mounted, so this covers being suspended at an event, but also other situations in which the virtual thread is mounted.
> 
> JDWP and JDI need to line up with JVMTI. Only spec changes will be needed.
> 
> A new test was added mostly to cover the unmounted virtual thread case that results in OpaqueFrameException.
> 
> forceEarlyReturn002 test had previously been updated for virtual threads to expect OpaqueFrameException. These changes have all been undone since the test now runs the same when using virtual threads as with platform threads.

This looks pretty good. Still need to review new test though.
I guess, you are in process to file a CSR for this.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14167#pullrequestreview-1445412028


More information about the serviceability-dev mailing list