RFR: 8309146: extend JDI StackFrame.setValue() and JDWP StackFrame.setValues minimal support for virtual threads
    Serguei Spitsyn 
    sspitsyn at openjdk.org
       
    Wed May 31 01:16:01 UTC 2023
    
    
  
On Tue, 30 May 2023 23:44:28 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
> The JDWP spec for StackFrame.SetValue currently states:
> 
>         "If the thread is a virtual thread then this command can be used to set "
>         "the value of local variables in the top-most frame when the thread is "
>         "suspended at a breakpoint or single step event. The target VM may support "
>         "setting local variables in other cases."
> 
> The JDI spec for StackFrame.setValue() has similar wording. In [JDK-8308814](https://bugs.openjdk.org/browse/JDK-8308814) the JVMTI spec clarified support to be for a thread suspended at any event, not just a breakpoint or single step. That same clarification is needed in the JDWP and JDI specs. No implementation changes are needed.
The fix looks good.
I've reviewed the CSR as well.
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14235#pullrequestreview-1452057650
    
    
More information about the serviceability-dev
mailing list