RFR: 8308232: nsk/jdb tests don't pass -verbose flag to the debuggee

Serguei Spitsyn sspitsyn at openjdk.org
Wed May 31 01:17:55 UTC 2023


On Wed, 31 May 2023 00:27:16 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> The nsk/jdb tests are not passing the test args on to the debuggee. I found a way to pass all of them (see the CR for details), but Windows had trouble with the parsing. It turns out the only args that the debuggee really cares about are -verbose and -waittime, so I settled on just passing these two, and Windows is happy.
> 
> Note only a handful of tests run with -verbose as the default. However, with this change at least now if you add -verbose when debugging an issue, you will see verbose log output from the debuggee. Previously you would not.

Looks good.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14236#pullrequestreview-1452058989


More information about the serviceability-dev mailing list