RFR: 8308286 Fix clang warnings in linux code [v2]
    Artem Semenov 
    asemenov at openjdk.org
       
    Wed May 31 13:41:04 UTC 2023
    
    
  
On Tue, 30 May 2023 08:14:59 GMT, Alexey Ushakov <avu at openjdk.org> wrote:
>> Artem Semenov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update
>
> src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 655:
> 
>> 653:       // linker loaded it. We use "base diff" in read_lib_segments call below.
>> 654: 
>> 655:                     if (ps_pdread(ph, (psaddr_t) link_map_addr + LINK_MAP_ADDR_OFFSET,
> 
> Extra white spaces before 'if'
done
> src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 662:
> 
>> 660: 
>> 661:       // read address of the name
>> 662:                       if (ps_pdread(ph, (psaddr_t) link_map_addr + LINK_MAP_NAME_OFFSET,
> 
> Extra white-spaces before 'if'
done
> src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 717:
> 
>> 715: 
>> 716:     // read next link_map address
>> 717:                     if (ps_pdread(ph, (psaddr_t) link_map_addr + LINK_MAP_NEXT_OFFSET,
> 
> Extra white-spaces before 'if'
done
> src/jdk.jpackage/share/native/common/tstrings.cpp line 60:
> 
>> 58: #endif
>> 59:         // With g++ this compiles only with '-std=gnu++0x' option
>> 60:                 ret = vsnprintf(&*fmtout.begin(), fmtout.size(), format, args);
> 
> Extra white-spaces before 'ret'
done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14033#discussion_r1211732345
PR Review Comment: https://git.openjdk.org/jdk/pull/14033#discussion_r1211734132
PR Review Comment: https://git.openjdk.org/jdk/pull/14033#discussion_r1211734711
PR Review Comment: https://git.openjdk.org/jdk/pull/14033#discussion_r1211735111
    
    
More information about the serviceability-dev
mailing list