RFR: 8307478: Implementation of Prepare to Restrict The Dynamic Loading of Agents [v4]

[Chris Plummer]

On Tue, 23 May 2023 14:08:11 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> test/jdk/com/sun/tools/attach/warnings/DynamicLoadWarningTest.java line 108:
>> 
>>> 106:         // no warning should be printed
>>> 107:         test((pid, vm) -> vm.loadAgentLibrary(JVMTI_AGENT_LIB), "-XX:+EnableDynamicAgentLoading")
>>> 108:                 .shouldNotContain(message);
>> 
>> How about adding a test case for `-XX:-EnableDynamicAgentLoading`. Same thing in `testJCmdJvmtiAgentLoad()` and `testLoadJavaAgent()` below.
>
> We can't currently test `jcmd JVMTI.agent_load` with `-XX:-EnableDynamicAgentLoading` due to JDK-8304438.

@AlanBateman  @sspitsyn Can this be revisited now that JDK-8304438 is being worked on? Perhaps the changes to JDK-8304438 can include an update to this test, although it all depends on which is being pushed first.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13899#discussion_r1212369828