RFR: JDK-8318636: Add jcmd to print annotated process memory map [v6]
Johan Sjölen
jsjolen at openjdk.org
Wed Nov 1 09:41:05 UTC 2023
On Wed, 1 Nov 2023 09:37:22 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> I'll do the former, that is clearer I agree, but leave the latter out (I assume with the macro you mean add it to globalDefenitions.hpp).
>>
>> I fear that a lot of bikeshedding and general discussions would start, and to do it properly needs a bit more time. Because we really would benefit from having a nice templatized utility classes for ranges. Like MemRegion, but that one is tied to HeapWord* I think.
>
> `MAX2` and `MIN2` are not macros, they're `constexpr` free functions, and that's what a `RANGE_INTERSECT` free function should be also. Unexpected because of their names, I know.
FWIW: Yeah, if it's going to be in globalDefinitions.hpp then do that in a separate RFE.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16301#discussion_r1378579763
More information about the serviceability-dev
mailing list