RFR: JDK-8319053: Segment dump files remain after parallel heap dump on Windows [v2]

Alex Menkov amenkov at openjdk.org
Thu Nov 2 21:42:04 UTC 2023


On Thu, 2 Nov 2023 06:09:22 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   updated log text
>
> src/hotspot/share/services/heapDumper.cpp line 1959:
> 
>> 1957:     // Delete selected segmented heap file nevertheless
>> 1958:     if (remove(path) != 0) {
>> 1959:       log_info(heapdump)("Remove segment file (%d) failed (%d)", i, errno);
> 
> Suggestion: "Removal of segment file ..."

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16462#discussion_r1380811214


More information about the serviceability-dev mailing list