RFR: 8319244: implement JVMTI handshakes support for virtual threads [v2]

Serguei Spitsyn sspitsyn at openjdk.org
Fri Nov 3 04:18:26 UTC 2023


> The handshakes support for virtual threads is needed to simplify the JVMTI implementation for virtual threads. There is a significant duplication in the JVMTI code to differentiate code intended to support platform, virtual threads or both. The handshakes are unified, so it is enough to define just one handshake for both platform and virtual thread.
> At the low level, the JVMTI code supporting platform and virtual threads still can be different.
> This implementation is based on the `JvmtiVTMSTransitionDisabler` class.
> 
> The internal API includes three new classes:
>   - `JvmtiHandshake`, `JvmtiUnifiedHandshakeClosure`, VM_HandshakeUnmountedVirtualThread
>   
>   The `JvmtiUnifiedHandshakeClosure` defines two different callback functions: `do_thread()` and `do_vthread()`.
> 
> The first JVMTI functions are picked first to be converted to use the `JvmtiHandshake`:
>  - `GetStackTrace`, `GetFrameCount`, `GetFrameLocation`, `NotifyFramePop`
> 
> To get the test results clean, the update also fixes the test issue:
> [8318631](https://bugs.openjdk.org/browse/JDK-8318631): GetStackTraceSuspendedStressTest.java failed with "check_jvmti_status: JVMTI function returned error: JVMTI_ERROR_THREAD_NOT_ALIVE (15)" 
> 
> Testing:
>  - the mach5 tiers 1-6 are all passed

Serguei Spitsyn has updated the pull request incrementally with two additional commits since the last revision:

 - address review: remove fix in libGetStackTraceSuspendedStress.cpp
 - addressed initial minor review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16460/files
  - new: https://git.openjdk.org/jdk/pull/16460/files/218d439f..7ef7dbbc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16460&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16460&range=00-01

  Stats: 64 lines in 4 files changed: 33 ins; 29 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/16460.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16460/head:pull/16460

PR: https://git.openjdk.org/jdk/pull/16460


More information about the serviceability-dev mailing list