RFR: JDK-8319053: Segment dump files remain after parallel heap dump on Windows [v2]

David Holmes dholmes at openjdk.org
Fri Nov 3 06:25:02 UTC 2023


On Thu, 2 Nov 2023 20:44:14 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Segment file is closed from DumpWriter dtor.
>> On Unix systems `remove` can delete an opened file, on Windows it fails with "access denied".
>> The fix destroys DumpWriter objects for segment files after all data are dumped
>
> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   updated log text

Thanks for the explanation. Looks fine.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16462#pullrequestreview-1711885352


More information about the serviceability-dev mailing list