RFR: 8319238: JMX ThreadPoolAccTest.java is too verbose and should fail before timeout

[Serguei Spitsyn]

On Thu, 2 Nov 2023 18:16:49 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> test/jdk/javax/management/monitor/ThreadPoolAccTest.java line 167:
>> 
>>> 165:             String expected = principals[i / 3];
>>> 166: 
>>> 167:             echo("testPrincipals: monitored: " + monitored[i] + " principal: " + principal + " expected: " + expected);
>> 
>> With this in place, should printing of principal at line 176 be removed?
>
> Right, it is duplicated.  That new line is useful, I really wanted to see something before we check for null.
> Then we have the existing printing before we check further, which I did not disturb.  I'm sure it's not a big deal either way.

Up to you.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16456#discussion_r1381203169