RFR: JDK-8318636: Add jcmd to print annotated process memory map [v9]

[David Holmes]

On Thu, 9 Nov 2023 07:26:46 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix another windows error
>
> src/hotspot/share/services/diagnosticCommand.cpp line 1159:
> 
>> 1157: }
>> 1158: 
>> 1159: SystemMapDCmd::SystemMapDCmd(outputStream* output, bool heap) :
> 
> Shouldn't this all be inside `ifdef LINUX`? You don't need `os::realpath` if you do that.

Well to call `os::Posix::realpath` it would need Linux specific includes ... but as it is you have unused code in the Windows version.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16301#discussion_r1387589586