RFR: 8318895: Deoptimization results in incorrect lightweight locking stack [v2]

[Richard Reingruber]

On Thu, 9 Nov 2023 15:54:13 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> See JBS issue for details.
>> 
>> I basically:
>>  - took the test-modification and turned it into its own test-case
>>  - added test runners for lightweight- and legacy-locking, so that we keep testing both, no matter what is the default
>>  - added Axels fix (mentioned in the JBS issue) with the modification to only inflate when exec_mode == Unpack_none, as explained by Richard.
>> 
>> Testing:
>>  - [x] EATests.java
>>  - [x] tier1
>>  - [ ] tier2
>
> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add @reinrich's test-case

Fix and new test case look good to me.
Local testing was clean.
Thanks, Richard.

test/jdk/com/sun/jdi/EATests.java line 1755:

> 1753: /////////////////////////////////////////////////////////////////////////////
> 1754: 
> 1755: // The debugger reads and publishes an object with eliminated locking to a static variable.

Suggestion:

// The debugger reads and publishes an object with eliminated locking to an instance field.

-------------

Marked as reviewed by rrich (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16568#pullrequestreview-1724167589
PR Review Comment: https://git.openjdk.org/jdk/pull/16568#discussion_r1389009395