RFR: JDK-8318636: Add jcmd to print annotated process memory map [v9]

[Thomas Stuefe]

On Thu, 9 Nov 2023 07:03:34 GMT, David Holmes <dholmes at openjdk.org> wrote:

>>> > As this adds a JCmd, doesn't this need both a CSR and a manual entry?
>>> 
>>>     * CSR: not sure; there are precedences for going with CSR and without CSR. Since we get awfully close to JDK22 freeze, I would prefer for a CSR not to be needed. Also would make backporting a lot easier.
>>> 
>>>     * Manpage: not sure either; IIRC last time I tried, I was told that Oracle maintains these internally, because there is internal documentation that needs updating too?
>> 
>> @dholmes-ora, would you mind helping us out here with regards to the process? Would a new JCmd require a CSR or would it be acceptable to merge without one? Thank you.
>
>> > > As this adds a JCmd, doesn't this need both a CSR and a manual entry?
>> > 
>> > 
>> > ```
>> > * CSR: not sure; there are precedences for going with CSR and without CSR. Since we get awfully close to JDK22 freeze, I would prefer for a CSR not to be needed. Also would make backporting a lot easier.
>> > 
>> > * Manpage: not sure either; IIRC last time I tried, I was told that Oracle maintains these internally, because there is internal documentation that needs updating too?
>> > ```
>> 
>> @dholmes-ora, would you mind helping us out here with regards to the process? Would a new JCmd require a CSR or would it be acceptable to merge without one? Thank you.
> 
> @jdksjolen No CSR needed: from another related PR - "We do not use CSR requests with jcmd changes as they are deemed diagnostic commands - ref JDK-8203682"
> 
> But yes the `jcmd` manpage should be updated ref:
> https://docs.oracle.com/en/java/javase/19/docs/specs/man/jcmd.html
> though I'm worried we may not have kept it up to date! That requires an Oracle engineer to apply the changes to the jcmd.md markdown sources in our repo, and then regenerate the `jcmd.1` manpage file. The doc update can be split into a separate doc sub-task so that the main PR is not held up. (And we probably need an audit to see if any other updates are missing - which is painful.)

Thanks @dholmes-ora !



> Thanks for the updates @tstuefe - nothing further from me (with the Windows variant in the pipeline I will wait and see how things look in terms of shared versus platform-specific code.
> 
> Please create a JBS issue to get this new command documented in the jcmd manpage, with details on what that documentation should look like.

There are a number of inconsistencies apart from this new dcmd; I think the jcmd man page needs to be updated.

I collected all inconsistencies I could spot in this issue: https://bugs.openjdk.org/browse/JDK-8319948 and put it onto your name.

> 
> Thanks

Thank you, David.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16301#issuecomment-1807663916