RFR: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks

David Holmes dholmes at openjdk.org
Tue Nov 14 07:45:29 UTC 2023


On Tue, 14 Nov 2023 06:50:58 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> Zero'ing memory of extension event callbacks

Marked as reviewed by dholmes (Reviewer).

src/hotspot/share/prims/jvmtiEnvBase.cpp line 217:

> 215:   // all callbacks initially null
> 216:   memset(&_event_callbacks,0,sizeof(jvmtiEventCallbacks));
> 217:   memset(&_ext_event_callbacks, 0, sizeof(jvmtiExtEventCallbacks));

Looks good.

While you are here could you adjust the existing memset line and add spaces after the commas please. Thanks.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16647#pullrequestreview-1729084003
PR Review Comment: https://git.openjdk.org/jdk/pull/16647#discussion_r1392118874


More information about the serviceability-dev mailing list