RFR: 8316342: CLHSDB "dumpclass" command produces invalid classes

[Ashutosh Mehra]

On Thu, 28 Sep 2023 23:40:58 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Please review this change to fix the operands of the bytecodes that operate on fields when dumping a class using SA.
>> 
>> Testing: hotspot_serviceability
>> 
>> I have also verified that `test/hotspot/jtreg/serviceability/sa/ClhsdbDumpclass.javaClhsdbDumpclass.java`, which is in the problem list because of this issue, passes with this change.
>> I have also verified it by dumping the class that has getstatic/putstatic bytecodes and comparing the bytecodes manually with the original classfile.
>
> Ok. The changes look good to me, but I don't have much of understanding of the hotspot code involved here, so I'll defer to a hotspot expert for the 2nd review.

I am returning from a break. Thanks @plummercj @sspitsyn for reviewing the changes.
It looks like this doesn't have any merge conflicts, so can still be integrated.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15973#issuecomment-1810366426