RFR: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks [v2]

Roman Marchenko rmarchenko at openjdk.org
Wed Nov 15 07:38:39 UTC 2023


On Tue, 14 Nov 2023 20:51:22 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing review comments
>
> Just a heads up that HotSpot code normally requires two reviews (1 from a (R)eviewer)
> and 24 hours unless it is called trivial AND agreed to be trivial by your reviewers.

@dcubed-ojdk Sorry, I didn't know that. Could you point the discussion about +24 hours waiting please?

BTW I seems like both requirements may be automated in github.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16647#issuecomment-1811943616


More information about the serviceability-dev mailing list