RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method [v3]

David Holmes dholmes at openjdk.org
Thu Nov 16 06:07:33 UTC 2023


On Wed, 15 Nov 2023 09:38:25 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>>> I still approve of this patch as it's better than what we had before. There are a lot of suggested improvements that can be done either in this PR or in a future RFE. `git blame` shows that this hasn't been touched since 2008, so I don't think applying all suggestions now is in any sense critical :-).
>> 
>> Not touched since 2008 suggests to me there might not be a rush to make the change as proposed, and instead take
>> the (I think small) additional time to do the better thing, e.g. the unary-predicate suggestion made by several folks.
>
> @kimbarrett , @dholmes-ora , @merykitty 
> Is there any comment on this PR?

@afshin-zafari I will leave it to other to (re-) review the latest changes. I don't grok this template stuff enough to pass judgement.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15418#issuecomment-1813839612


More information about the serviceability-dev mailing list