RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method [v3]

Stefan Karlsson stefank at openjdk.org
Fri Nov 17 13:34:36 UTC 2023


On Fri, 17 Nov 2023 13:20:22 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> @kimbarrett , @dholmes-ora , @merykitty 
>> Is there any comment on this PR?
>
>> @afshin-zafari I will leave it to other to (re-) review the latest changes. I don't grok this template stuff enough to pass judgement.
> 
> Thank you very much @dholmes-ora, for your comments and discussions.

@afshin-zafari I think you misunderstand the feedback given. The suggestions from many of us has been that you should change the functions to accept lambdas / template-typed functions instead.

https://github.com/openjdk/jdk/pull/15418#discussion_r1305389552
https://github.com/openjdk/jdk/pull/15418#discussion_r1375386257
https://github.com/openjdk/jdk/pull/15418#discussion_r1376940244
https://github.com/openjdk/jdk/pull/15418#discussion_r1395219935

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15418#issuecomment-1816438451


More information about the serviceability-dev mailing list