RFR: 8313816: Accessing jmethodID might lead to spurious crashes [v3]

Jaroslav Bachorik jbachorik at openjdk.org
Thu Nov 23 08:49:37 UTC 2023


On Wed, 22 Nov 2023 01:27:25 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> I see, holder is the right word and concept.  So the parameter means has_method_holder, in that the InstanceKlass has been fully parsed at the point of clearing the jmethodIDs.
>
> Can't we just check `method->method_holder()` for null rather than passing in a parameter like this?

Yes. I changed the code to do that. We will attempt to resolve the method holder for each method instead of just using one single boolean argument but I believe the resolution should be fast enough not to matter in this context.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16662#discussion_r1403068144


More information about the serviceability-dev mailing list