RFR: 8313816: Accessing jmethodID might lead to spurious crashes [v3]
Jaroslav Bachorik
jbachorik at openjdk.org
Thu Nov 23 08:49:39 UTC 2023
On Wed, 22 Nov 2023 01:21:15 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Jaroslav Bachorik has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Rewerite the test to use RedefineClassHelper
>
> test/hotspot/jtreg/serviceability/jvmti/thread/GetStackTrace/GetStackTraceAndRetransformTest/GetStackTraceAndRetransformTest.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2023 Oracle and/or its affiliates. All rights reserved.
>
> An Oracle copyright is not needed here if you wrote this test from scratch. If it is present then we need a comma after the copyright year please.
Fixed
> test/hotspot/jtreg/serviceability/jvmti/thread/GetStackTrace/GetStackTraceAndRetransformTest/libGetStackTraceAndRetransformTest.cpp line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2023 Oracle and/or its affiliates. All rights reserved.
>
> Ditto comment about Oracle copyright.
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16662#discussion_r1403054811
PR Review Comment: https://git.openjdk.org/jdk/pull/16662#discussion_r1403055037
More information about the serviceability-dev
mailing list