RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method [v10]

[Afshin Zafari]

On Thu, 23 Nov 2023 10:52:35 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> The `find` method now is 
>> ```C++
>> template<typename T>
>> int find(T* token, bool f(T*, E)) const {
>> ...
>> 
>> Any other functions which use this are also changed.
>> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and Windows passed.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Some cleanups, documentaions and tests.

> Thanks for making this change.
> 
> I'd like to suggest the following cleanups, some documentation, and a few tests: [20d4502](https://github.com/openjdk/jdk/commit/20d4502471ba396ae395512cfa3dab3f87555421)
> 
> I think it might be easier to review by looking at the final diff: [master...stefank:jdk:pr_15418](https://github.com/openjdk/jdk/compare/master...stefank:jdk:pr_15418)

One question: the `private static bool by_name(const char* name, PerfData* pd);` is added to `PerfDataList` class but is never used.  Is something missing?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15418#issuecomment-1824226437