RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method [v10]

[Stefan Karlsson]

On Thu, 23 Nov 2023 13:32:23 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>>> > Thanks for making this change.
>>> > I'd like to suggest the following cleanups, some documentation, and a few tests: [20d4502](https://github.com/openjdk/jdk/commit/20d4502471ba396ae395512cfa3dab3f87555421)
>>> > I think it might be easier to review by looking at the final diff: [master...stefank:jdk:pr_15418](https://github.com/openjdk/jdk/compare/master...stefank:jdk:pr_15418)
>>> 
>>> One question: the `private static bool by_name(const char* name, PerfData* pd);` is added to `PerfDataList` class but is never used. Is something missing?
>> 
>> That should have been removed when I added name_equals.
>
> @stefank,  the changes are applied as suggested and ready for review.

@afshin-zafari you toke my changes and then you made a few small whitespace changes that messed up the patch. I merged our two branches to correct those issues. Could you make sure to pull the changes from my branch (don't copy the changes):
https://github.com/stefank/jdk/tree/pr_15418

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15418#issuecomment-1824474455