RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method [v3]

[David Holmes]

On Thu, 23 Nov 2023 22:15:35 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>>> I still approve of this patch as it's better than what we had before. There are a lot of suggested improvements that can be done either in this PR or in a future RFE. `git blame` shows that this hasn't been touched since 2008, so I don't think applying all suggestions now is in any sense critical :-).
>> 
>> Not touched since 2008 suggests to me there might not be a rush to make the change as proposed, and instead take
>> the (I think small) additional time to do the better thing, e.g. the unary-predicate suggestion made by several folks.
>
> Dear @kimbarrett , @dholmes-ora , @stefank, @rose00 , @jdksjolen, @sspitsyn, @merykitty, 
> Thank you all. 
> The final code is now cleaner and nicer.

@afshin-zafari I'm happy to hear the code is now cleaner and nicer, but AFAICS this new version of the code has only had a single review. It should really have been re-reviewed by at least one of the earlier reviewers. Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15418#issuecomment-1825200669