RFR: 8320652: ThreadInfo.isInNative needs to be updated to say what executing native code means [v2]

[David Holmes]

On Tue, 28 Nov 2023 06:00:54 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> This `isInNative` method intends to provide a way to tell if the thread has transitioned from executing Java method to a native method.  JVM interpreter and compiler provide the support for Java language which is why I think such clarification might not be highly necessary.
>
> FWIW I would not remove the "does not include ..." information otherwise people may wrongly infer that in the past this method would not return true for VM code or generated code, but that now it does.

Note that there is no answer for the "syscall" case mentioned as it depends on the code that makes the syscall: if from a native method then yes; if from the VM then no.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16791#discussion_r1407270500