RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump
Taizo Kurashige
duke at openjdk.org
Tue Nov 28 07:41:10 UTC 2023
On Mon, 30 Oct 2023 22:39:34 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Hi,
>>
>> I fixed the typos for JFR.start and JFR.dump.
>> Acconding to issue's description, there is some typo in JFR.stop documentation, but I couldn't find that. I confirmed that there is no such typo in this repository. So I thought there was no need to fix JFR.stop documentation.
>>
>> I confirmed that the fixes are reflected and that all of the jdk_jfr tests pass.
>>
>> Could someone please review it?
>
> src/jdk.jcmd/share/man/jcmd.1 line 1:
>
>> 1: .\" Copyright (c) 2012, 2023, Oracle and/or its affiliates. All rights reserved.
>
> This file is generated from markdown sources that Oracle has to maintain. Please work with an Oracle engineer to get the changes applied to that source and then regenerate the `jcmd.1` nroff file. You can split this into a separate sub-task if needed.
Thank you for telling me about how to jcmd.1 nroff file is managed.
I will split this change into separate subtasks. Then if one of the Oracle engineers finds that subtask, will he/she work on it like any other bug?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16413#discussion_r1407338498
More information about the serviceability-dev
mailing list