RFR: 8319935: Ensure only one JvmtiThreadState is created for one JavaThread associated with attached native thread [v5]
Serguei Spitsyn
sspitsyn at openjdk.org
Tue Nov 28 20:46:12 UTC 2023
On Wed, 22 Nov 2023 22:40:20 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
>> Please review JvmtiThreadState::state_for_while_locked change to handle the state->get_thread_oop() null case. Please see https://bugs.openjdk.org/browse/JDK-8319935 for details.
>
> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>
> Address Serguei Spitsyn's comments/suggestions:
> - Remove the redundant thread->is_Java_thread() check from JvmtiSampledObjectAllocEventCollector::object_alloc_is_safe_to_sample().
> - Change the assert in JvmtiThreadState::state_for_while_locked to avoid #ifdef ASSERT.
This fix looks good to me, so approved now.
I assume it is for 22. Is it correct?
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16642#pullrequestreview-1753899489
More information about the serviceability-dev
mailing list