RFR: 8313816: Accessing jmethodID might lead to spurious crashes [v10]

[Jaroslav Bachorik]

On Tue, 28 Nov 2023 21:30:16 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Jaroslav Bachorik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unnecessary assert
>
> src/hotspot/share/oops/instanceKlass.cpp line 4236:
> 
>> 4234:     if (method != nullptr) {
>> 4235:       method->clear_jmethod_id();
>> 4236:     }
> 
> This loops through the methods in the InstanceKlass that was a previous version klass, and clears the jmethodIDs for all the methods.  Will it clear the jmethodIDs for the EMCP methods also, and should it?
> The jmethodID for EMCP methods are replaced with a the new version, so the Method* in this list won't find a matching jmethodID.  Maybe this can be restricted to obsolete methods?

Restricting to obsolete methods sounds like a good idea.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16662#discussion_r1409164812