RFR: 8313816: Accessing jmethodID might lead to spurious crashes [v10]

[Jaroslav Bachorik]

On Wed, 29 Nov 2023 14:57:34 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> Can you confirm my observation above, that EMCP jmethodIDs are replaced?  I haven't looked at this code in a while.  Thanks.
>
> I am going to take a look.

Ok, I found it.
The reason for the jmethodID not being cleaned out is this assignment of a new jmethodID to obsolete methods - https://github.com/openjdk/jdk/blob/a2c5f1fc914ef5c28d044b75598f895cf6097138/src/hotspot/share/prims/jvmtiRedefineClasses.cpp#L3887

Since this is not done for EMCP (or more generic, non-obsolete) methods restricting the cleanup process to obsolete methods still sounds like the right thing to do.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16662#discussion_r1409436435