RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v47]

Jonathan Joo jjoo at openjdk.org
Thu Nov 30 00:06:18 UTC 2023


On Thu, 23 Nov 2023 12:43:00 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cleanup and address comments
>
> src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 2433:
> 
>> 2431:   }
>> 2432:   WorkerThreads* worker_threads = workers();
>> 2433:   if (worker_threads != nullptr) {
> 
> When will this be null?

I guess it shouldn't be, since it is set when we call initialize() and also never unset. I'll remove this conditional.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15082#discussion_r1410005989


More information about the serviceability-dev mailing list