RFR: 8320860: add-opens/add-exports require '=' in JAVA_TOOL_OPTIONS

Thu Nov 30 08:46:05 UTC 2023

On Thu, 30 Nov 2023 04:30:28 GMT, David Holmes <dholmes at openjdk.org> wrote:

> I do not believe this clarification needs a CSR request.

I agree, there isn't any new testable assertion here as it is already in the JNI spec.

src/hotspot/share/prims/jvmti.xml line 746:

> 744:     <code>JNI_CreateJavaVM</code> (in the JNI Invocation API) will prepend these options to the options supplied
> 745:     in its <code>JavaVMInitArgs</code> argument. Note that module related options must be expressed in their
> 746:     "option=value" form (not "option value") for <code>JNI_CreateJavaVM</code> to process them correctly.

This looks okay. I'm just comparing it to the text that we put into the JNI spec:

"The module related options ... as option strings using their "option=value" format instead of their "option value" format. (Note the required = between "option" and "value".)"

It uses "format" instead of "form" and also, the bit I think words well, is to point the out the "required =" to force the reader to re-read the previous sentence and see what the difference is in the formats.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16896#issuecomment-1833328234
PR Review Comment: https://git.openjdk.org/jdk/pull/16896#discussion_r1410333900