RFR: 8316342: CLHSDB "dumpclass" command produces invalid classes
Serguei Spitsyn
sspitsyn at openjdk.org
Tue Oct 3 09:52:38 UTC 2023
On Thu, 28 Sep 2023 21:23:25 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:
> Please review this change to fix the operands of the bytecodes that operate on fields when dumping a class using SA.
>
> Testing: hotspot_serviceability
>
> I have also verified that `test/hotspot/jtreg/serviceability/sa/ClhsdbDumpclass.javaClhsdbDumpclass.java`, which is in the problem list because of this issue, passes with this change.
> I have also verified it by dumping the class that has getstatic/putstatic bytecodes and comparing the bytecodes manually with the original classfile.
Nice simplification.
This looks good.
Thanks,
Serguei
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15973#pullrequestreview-1654803061
More information about the serviceability-dev
mailing list