RFR: 8316464: 3 sun/tools tests ignore VM flags

Chris Plummer cjplummer at openjdk.org
Fri Oct 6 23:37:12 UTC 2023


On Fri, 6 Oct 2023 19:24:03 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> I marked tests 
> sun/tools/jcmd/TestProcessHelper.java
> sun/tools/jinfo/JInfoTest.java
> as headless. They used different specific VM options and are not worth executing with other VM flags. 
> And fixed 
> sun/tools/jstat/JStatInterval.java
> Tested with tier1, local execution of tests, and running sun/tools/jstat/JStatInterval.java with different options.

test/jdk/sun/tools/jinfo/JInfoTest.java line 41:

> 39:  * @summary Unit test for jinfo utility
> 40:  *
> 41:  * @requires vm.flagless

I'm not so sure about this one. There are a number of things that change in the output based on JVM args. It would seem we would want to test this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16078#discussion_r1349391765


More information about the serviceability-dev mailing list