RFR: JDK-8316691: Heap dump: separate stack traces for mounted virtual threads [v3]

[Alex Menkov]

On Fri, 6 Oct 2023 19:13:26 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   misspell getRefererId for consistency
>
> src/hotspot/share/services/heapDumper.cpp line 1494:
> 
>> 1492: class ThreadDumper : public CHeapObj<mtInternal> {
>> 1493: public:
>> 1494:   enum class ThreadType {Platform, MountedVirtual, UnmountedVirtual};
> 
> Please, add space after `{` and before `}`.

done

> test/hotspot/jtreg/serviceability/jvmti/vthread/HeapDump/VThreadInHeapDump.java line 241:
> 
>> 239:             test(snapshot, VThreadInHeapDumpTarg.VThreadMountedReferenced.class);
>> 240:             test(snapshot, VThreadInHeapDumpTarg.PThreadReferenced.class);
>> 241:             //test(snapshot, VThreadInHeapDumpTarg.VThreadUnmountedReferenced.class);
> 
> It'd be nice to add a comment explaining why this line was commented out.

added

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15869#discussion_r1349415086
PR Review Comment: https://git.openjdk.org/jdk/pull/15869#discussion_r1349415099