RFR: 8316233: VirtualThreadStart events should not be thread-filtered [v2]
Chris Plummer
cjplummer at openjdk.org
Tue Oct 10 00:12:57 UTC 2023
On Mon, 9 Oct 2023 23:52:40 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> src/hotspot/share/prims/jvmtiExport.cpp line 1581:
>>
>>> 1579: assert(!thread->is_hidden_from_external_view(), "carrier threads can't be hidden");
>>> 1580:
>>> 1581: // Do not post virtual thread start event for hidden java thread.
>>
>> Why would we ever have a hidden virtual thread? Also, why is this comment here. It is also below, which seems to be the more appropriate location.
>
> Good catch, thanks. Forgot to remove this comment. Fixed now.
I still would like to know how we might end up with a hidden virtual thread.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16019#discussion_r1351024365
More information about the serviceability-dev
mailing list