RFR: 8316233: VirtualThreadStart events should not be thread-filtered [v4]
Chris Plummer
cjplummer at openjdk.org
Tue Oct 10 02:48:09 UTC 2023
On Tue, 10 Oct 2023 00:54:42 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> The JVMTI VirtualThreadStart events have to follow the ThreadStart events pattern and so, should not be thread-filtered.
>> The fix includes:
>> - `jvmti.xml`: remov the attribute `filtered="thread"` in the `VirtuallThreadStart` event spec
>> - `jvmtiEventController.cpp`: remove the `VTHREAD_START_BIT` from the `THREAD_FILTERED_EVENT_BITS` mask and and it to the `NEED_THREAD_LIFE_EVENTS` mask
>> - `jvmtiExport.cpp`: rearrangements in the `JvmtiExport::post_vthread_start()` function
>>
>> The fix also includes a couple of minor unification tweaks:
>> - to align `JvmtiExport::post_thread_end()` with `JvmtiExport::post_vthread_end()` to have a unified check for the `JVMTI_PHASE_PRIMORDIAL`.
>> - to rename the local variable `cur_thread` as `thread` to follow the common pattern in `JvmtiExport::post_vthread_start()` and `JvmtiExport::post_vthread_end()`
>>
>> Testing: ran mach5 tiers 1-6. All tests are passed.
>
> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>
> review: convert hidden thread check for vthread end into assert as for vthread start
Marked as reviewed by cjplummer (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/16019#pullrequestreview-1665882344
More information about the serviceability-dev
mailing list