Integrated: 8316233: VirtualThreadStart events should not be thread-filtered
Serguei Spitsyn
sspitsyn at openjdk.org
Tue Oct 10 03:09:14 UTC 2023
On Mon, 2 Oct 2023 23:11:01 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
> The JVMTI VirtualThreadStart events have to follow the ThreadStart events pattern and so, should not be thread-filtered.
> The fix includes:
> - `jvmti.xml`: remov the attribute `filtered="thread"` in the `VirtuallThreadStart` event spec
> - `jvmtiEventController.cpp`: remove the `VTHREAD_START_BIT` from the `THREAD_FILTERED_EVENT_BITS` mask and and it to the `NEED_THREAD_LIFE_EVENTS` mask
> - `jvmtiExport.cpp`: rearrangements in the `JvmtiExport::post_vthread_start()` function
>
> The fix also includes a couple of minor unification tweaks:
> - to align `JvmtiExport::post_thread_end()` with `JvmtiExport::post_vthread_end()` to have a unified check for the `JVMTI_PHASE_PRIMORDIAL`.
> - to rename the local variable `cur_thread` as `thread` to follow the common pattern in `JvmtiExport::post_vthread_start()` and `JvmtiExport::post_vthread_end()`
>
> Testing: ran mach5 tiers 1-6. All tests are passed.
This pull request has now been integrated.
Changeset: d3139159
Author: Serguei Spitsyn <sspitsyn at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/d31391597433cf275fc615e0148c48c34acf6e11
Stats: 32 lines in 3 files changed: 7 ins; 10 del; 15 mod
8316233: VirtualThreadStart events should not be thread-filtered
Reviewed-by: lmesnik, amenkov, cjplummer
-------------
PR: https://git.openjdk.org/jdk/pull/16019
More information about the serviceability-dev
mailing list